Skip to content

LXC/Getting started: Add --clear-env flag to lxc-attach to prevent common roadblock for newcomers.#801

Merged
stgraber merged 1 commit into
lxc:mainfrom
nordtektiger:main
Feb 2, 2026
Merged

LXC/Getting started: Add --clear-env flag to lxc-attach to prevent common roadblock for newcomers.#801
stgraber merged 1 commit into
lxc:mainfrom
nordtektiger:main

Conversation

@nordtektiger
Copy link
Copy Markdown
Contributor

This patch adds --clear-env to every invocation of lxc-attach in the Getting Started page for LXC. The omission of this flag can cause issues on certain distributions and since this page does not seem to utilize the passing of environment variables to the container, simply adding the flag strikes me as a trivial solution. See #796 for more details.

Happy to revise this patch as the maintainers see fit.

Signed-off-by: Jacob Aulin <jacob.aulin@pm.me>
@stgraber
Copy link
Copy Markdown
Member

stgraber commented Feb 1, 2026

Your commit is missing the required Signed-off-by string in the commit message, could you add that?

@nordtektiger
Copy link
Copy Markdown
Contributor Author

The commit is, in fact, signed off, albeit using my real name rather than my username. The contributing.md file stated that "no pseudonyms or anonymous contributions are allowed," which is why I changed it to say Jacob Aulin instead of nordtektiger. This seems to have tripped the GitHub action?

I could absolutely go back and amend the commit, changing it into my username instead if that's preferable. I guess the contribution specification is just a little unclear regarding the DCO, in that case.

Do let me know if it's passable as is, or if I should amend the commit message. Thank you for maintaining the linuxcontainers.org website, by the way, I greatly appreciate it.

@stgraber
Copy link
Copy Markdown
Member

stgraber commented Feb 2, 2026

Ah, that's fine, it's just the checker being overly pick about the two fields lining up :)

@stgraber stgraber merged commit 0c2549c into lxc:main Feb 2, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants