Add Cookies recipe - #155
Conversation
katrinafyi
left a comment
There was a problem hiding this comment.
Generally looks good. Just wondering if there's a citation for this format somewhere upstream?
Also, the raw_cookie field seems to repeat information which is also in separate fields. Maybe that's just what it is, but it's a bit odd.
|
Thanks for all the review. I tried my best to fill in the gaps now. And yes, it feels like there's some redundancy in the format, but that's a limitation of the crate we're using. At least from their source code, I currently can't see any better way to pass the data to cookie_store. lychee has essentially zero control here.
So the on-disk format is entirely And come to think of it, the fields aren't truly redundant. The three parsed fields capture state that the raw
So the parsed fields serve a slightly different purpose (provenance?). I was thinking about adding a note to the docs, but I decided that most people won't care and that it could be too much information and get confusing. But great observation! |
|
Guess all comments have been addressed for now (thanks!). Merging. |
Adds a short recipe page documenting the
--cookie-jaroption and the JSON format of the cookie jar file.Fixes lycheeverse/lychee#1851
Related to lycheeverse/lychee#2215.