Fix pnpm dev commands on pnpm 9 - #157
Closed
mre wants to merge 1 commit into
Closed
Conversation
PR #153 added a pnpm-workspace.yaml to approve esbuild/sharp build scripts, but pnpm 9 treats that file as a workspace root and requires a 'packages' field, breaking every pnpm command (e.g. 'make watch'). Move the build-script approval to package.json's pnpm.onlyBuiltDependencies, which both pnpm 9 and 10 honor, and remove the workspace file.
Merged
Member
Author
|
Closing in favor of #158. This approach is incorrect: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pnpm-workspace.yaml added in #153 breaks pnpm 9: pnpm 9 treats the file as a workspace root and requires a
packagesfield, so every pnpm command (includingmake watch) fails withERROR packages field missing or empty.Move the esbuild/sharp build-script approval to
package.json'spnpm.onlyBuiltDependencies(honored by both pnpm 9 and 10) and remove the workspace file.