Update README.md - #171
Conversation
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ### hybrid_alpha Parameter Effect | ||
|
|
||
| `hybrid_alpha` weights RRF fusion between semantic and BM25 rankings on the **hybrid pipeline only**. When `search_method="auto"` and the QueryRouter classifies the query as lexical (e.g. `CVE-2021-4034`, `MDR-AD002`, `T1078.001`, file hashes), the FTS5 fast-path fires and `hybrid_alpha` is not consulted — FTS5 uses SQLite's native `bm25()` scoring exclusively. Pass `search_method="hybrid"` to force RRF fusion + rerank on every query if you want deterministic hybrid semantics regardless of the query shape. | ||
| `hybrid_alpha` weights RRF fusion between semantic and BM25 rankings on the **hybrid pipeline only**. When `search_method="auto"` and the QueryRouter classifies the query as lexical (e.g. `CVE-2021-4034`, `C2-CLOUDFLARE`, `T1078.001`, file hashes), the FTS5 fast-path fires and `hybrid_alpha` is not consulted — FTS5 uses SQLite's native `bm25()` scoring exclusively. Pass `search_method="hybrid"` to force RRF fusion + rerank on every query if you want deterministic hybrid semantics regardless of the query shape. |
There was a problem hiding this comment.
When C2-CLOUDFLARE is submitted with search_method="auto", it matches none of the default lexical patterns and is classified as semantic, so the hybrid pipeline consults hybrid_alpha despite the README claiming that the FTS5 fast path fires.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 421
Comment:
**Lexical routing example is invalid**
When `C2-CLOUDFLARE` is submitted with `search_method="auto"`, it matches none of the default lexical patterns and is classified as semantic, so the hybrid pipeline consults `hybrid_alpha` despite the README claiming that the FTS5 fast path fires.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
1 participant
Summary
Closes #
Type of change
What changed
Why
7 Pillars Quality Gate
1. Security
eval,exec,subprocess shell=True,pickle.loadson untrusted input, or arbitrary deserialization2. Stability
time.sleep/ network / OS-scheduler dependencies)xfailto make the PR pass3. Memory leak
4. Versatility
pathlib.Path,encoding="utf-8"explicit)5. Scalability
pytest bench/locally if you touched search/index/embed)Performance impact (required if you touched
mcp_server/server.py,mcp_server/ingestion.py, orbench/):6. Versioning
pyproject.toml,mcp_server/__init__.py, andnpm/package.jsonatomicallyBREAKING CHANGE:in commit footer## Unreleasedin README.mdmcp_server/server.pyMCP tool decorators) unchanged, OR breaking changes documented7. Quality
ruff checkpassesruff format --checkpassesmypy --strictclean for new files)interrogate)radon cc --max=C)vulturewould not flag new code)Migration / Breaking changes
N/A
Test plan
pytest tests/ -vpassed locallypre-commit run --all-filescleanDocumentation
README.md(if user-facing)docs/(if applicable)## Unreleasedin README CHANGELOG sectionReviewer checklist
By submitting this PR I confirm I read CONTRIBUTING.md and agree to the Code of Conduct.
Greptile Summary
The PR updates one lexical-query example in the README's explanation of
hybrid_alpha.MDR-AD002withC2-CLOUDFLARE.Confidence Score: 4/5
The inaccurate routing example should be corrected before merging because it reverses the documented behavior of
hybrid_alphafor that query.Under the default patterns,
C2-CLOUDFLAREdoes not trigger lexical routing, so auto search uses the hybrid pipeline despite the README claiming otherwise.Files Needing Attention: README.md
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Update README.md" | Re-trigger Greptile