fix: canonical term size model for shell resize#13
Merged
Conversation
Replace fire-and-forget resize events with a canonical term size state model. Term size is now block-level canonical state (stored in DB), not an event racing through the controller input channel. Key changes: - Add ApplyTermSize to Controller interface (Shell/Session/Tsunami) - Add SetTerminalSize(blockId, size): write DB canonical + best-effort apply - Add getLatestTermSize(blockId): fresh DB read for shell startup - New SetTerminalSizeCommand RPC; frontend syncControllerTermSize uses it - run() and startNewJob() read canonical size instead of rtOpts snapshot - ResyncController writes rtOpts.TermSize to canonical on entry - ControllerInputCommand handler strips TermSize (routes to SetTerminalSize) - Remove updateTermSize and term-size handling from ShellController input goroutine Invariants: - resize always writes canonical state first - shell startup always reads fresh canonical from DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fire-and-forget resize events with a canonical term size state model. Term size is now block-level canonical state (stored in DB), not an event racing through the controller input channel.
Key changes:
Invariants: