fix: enforce MCP execution bounds - #255
Closed
lzehrung wants to merge 4 commits into
Closed
Conversation
Three post-review defects in the MCP HTTP transport and raw SQLite query path: 1. Legacy initialize capacity reservations leaked whenever the SDK transport answered a pre-session 4xx without throwing (most notably Accept header validation): onsessioninitialized never fired to release it, and the catch block only covered thrown errors. Release the reservation whenever handleLegacyMcpSessionRequest resolves without a session having been initialized. 2. transport.onerror deleted the whole legacy session for any per-request SDK validation error (bad Accept, wrong Content-Type, malformed JSON, unsupported protocol version, ...), even though those already answered their own request and left the transport healthy. Session teardown is now driven by onclose alone; onerror only logs. 3. The in-process SQLite query fallback (used when the compiled worker asset can't be located) only checks its deadline between already-produced rows, so a statement slow to produce its first row isn't bounded by it. node:sqlite has no interrupt API, so true enforcement requires the worker thread this fallback exists because it couldn't find; corrected the public contract instead (JSDoc, docs/library-api.md, and a one-time degraded-mode log) so the gap is documented and observable rather than silently implied away.
Owner
Author
|
Superseded by #264, which consolidates the MCP session, transport, SQLite, and streaming fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification