Closed
Conversation
we should load nvdaControllerClient64.dll if library is 64 bit
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the NVDA controller client DLL was always loading the 32-bit version (nvdaControllerClient.dll), regardless of whether the application was built as 32-bit or 64-bit. The fix ensures that 64-bit builds load the correct 64-bit DLL (nvdaControllerClient64.dll).
Changes:
- Added preprocessor conditional to load
nvdaControllerClient64.dllfor 64-bit builds andnvdaControllerClient.dllfor 32-bit builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
In the latest NVDA Controller client, DLL names are same for 64 and 32 bit. |
Owner
|
In the latest NVDA Controller client, DLL names are same for 64/32 bit |
Contributor
Author
|
indeed closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we should load nvdaControllerClient64.dll if library is 64 bit