Skip to content

chore: add attribute logging in selectPlacements#533

Merged
nickolas-dimitrakas merged 1 commit intomainfrom
chore/add-attribute-logging-in-selectPlacements
Jan 29, 2026
Merged

chore: add attribute logging in selectPlacements#533
nickolas-dimitrakas merged 1 commit intomainfrom
chore/add-attribute-logging-in-selectPlacements

Conversation

@nickolas-dimitrakas
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Jan 29, 2026

What Has Changed

  • Added verbose log for the attributes that are passed into selectPlacements call

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Coupled with Rokt Kit PR

Reference Issue (For employees only. Ignore if you are an outside contributor)

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 9.37 MB 9.37 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1876,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1792,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9592}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1876,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1792,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9592}

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the chore/add-attribute-logging-in-selectPlacements branch from 959a393 to 1bc4f4f Compare January 29, 2026 20:16
@nickolas-dimitrakas nickolas-dimitrakas merged commit 875473a into main Jan 29, 2026
15 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the chore/add-attribute-logging-in-selectPlacements branch January 29, 2026 22:13
denischilik added a commit that referenced this pull request Feb 10, 2026
…ion/9.0-Merge-from-main

* commit '2bcac858729919f797cb799f98a44bf36cee8515':
  chore: Release v8.42.0 (#547)
  feat: Add support for Get / Set SessionId on Rokt (#536)
  chore: add attribute logging in selectPlacements (#533)
  chore: bump actions/setup-java from 4 to 5 (#500)
  chore: bump actions/checkout from 5 to 6 (#524)
  chore: bump peter-evans/create-or-update-comment from 4 to 5 (#523)
  chore: bump peter-evans/find-comment from 3 to 4 (#522)
  chore: bump actions/upload-artifact from 5 to 6 (#479)
  feat: Update mappings during the release process (#497)
  chore: bump actions/checkout from 5 to 6 (#458)
  ci: generate size reports (#496)
  chore: fix CHANGELOG.md entry for 8.41.0 (#509)
  chore: Fix common trunk issues (#510)
  chore: Release v8.41.1 (#506)
  chore: Release v8.41.0 (#504)
  fix:Correct Manual Release Action (#503)
  ci: Add Manual Release Workflow (#499)

# Conflicts:
#	IntegrationTests/wiremock-recordings/mappings/mapping-v4-config-get-config.json
BrandonStalnaker pushed a commit that referenced this pull request Feb 11, 2026
BrandonStalnaker pushed a commit that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants