chore: add attribute logging in selectPlacements#533
Merged
nickolas-dimitrakas merged 1 commit intomainfrom Jan 29, 2026
Merged
chore: add attribute logging in selectPlacements#533nickolas-dimitrakas merged 1 commit intomainfrom
nickolas-dimitrakas merged 1 commit intomainfrom
Conversation
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (main): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1876,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1792,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9592}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1876,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1792,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9592} |
jamesnrokt
reviewed
Jan 29, 2026
959a393 to
1bc4f4f
Compare
BrandonStalnaker
approved these changes
Jan 29, 2026
jamesnrokt
approved these changes
Jan 29, 2026
denischilik
added a commit
that referenced
this pull request
Feb 10, 2026
…ion/9.0-Merge-from-main * commit '2bcac858729919f797cb799f98a44bf36cee8515': chore: Release v8.42.0 (#547) feat: Add support for Get / Set SessionId on Rokt (#536) chore: add attribute logging in selectPlacements (#533) chore: bump actions/setup-java from 4 to 5 (#500) chore: bump actions/checkout from 5 to 6 (#524) chore: bump peter-evans/create-or-update-comment from 4 to 5 (#523) chore: bump peter-evans/find-comment from 3 to 4 (#522) chore: bump actions/upload-artifact from 5 to 6 (#479) feat: Update mappings during the release process (#497) chore: bump actions/checkout from 5 to 6 (#458) ci: generate size reports (#496) chore: fix CHANGELOG.md entry for 8.41.0 (#509) chore: Fix common trunk issues (#510) chore: Release v8.41.1 (#506) chore: Release v8.41.0 (#504) fix:Correct Manual Release Action (#503) ci: Add Manual Release Workflow (#499) # Conflicts: # IntegrationTests/wiremock-recordings/mappings/mapping-v4-config-get-config.json
BrandonStalnaker
pushed a commit
that referenced
this pull request
Feb 11, 2026
(cherry picked from commit 875473a)
BrandonStalnaker
pushed a commit
that referenced
this pull request
Feb 12, 2026
(cherry picked from commit 875473a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Has Changed
selectPlacementscallChecklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)