Skip to content

Fix CI workflow Go setup#116

Merged
grahamgilbert merged 1 commit into
mainfrom
codex/fix-ci-lint
Jul 21, 2026
Merged

Fix CI workflow Go setup#116
grahamgilbert merged 1 commit into
mainfrom
codex/fix-ci-lint

Conversation

@grahamgilbert

Copy link
Copy Markdown
Member

Summary

Updates CI workflows so they use the repository Go version from go.mod and current checkout/setup-go actions.

Root cause

The manual macOS build workflow still pinned Go 1.21 even though go.mod now requires Go 1.25. That is the same class of toolchain drift as the referenced failing lint run, where Actions selected mismatched Go/lint tooling and typechecking failed.

Changes

  • Move the manual macOS build checkout before Go setup so go-version-file: go.mod is available.
  • Update the manual macOS build workflow to actions/setup-go@v6 and actions/checkout@v6.
  • Update test and coverage workflows from actions/checkout@v3 to actions/checkout@v6.

Validation

  • golangci-lint v2.12.2 run returned 0 issues.
  • bazel test --test_output=errors //... passed 19/19 tests.
  • git diff --check passed.

@grahamgilbert grahamgilbert changed the title [codex] Fix CI workflow Go setup Fix CI workflow Go setup Jul 1, 2026
@grahamgilbert
grahamgilbert marked this pull request as ready for review July 1, 2026 07:49
@grahamgilbert
grahamgilbert requested review from a team and vdesouza July 1, 2026 07:50

@natewalck natewalck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamgilbert
grahamgilbert merged commit e58c4b5 into main Jul 21, 2026
10 checks passed
@grahamgilbert
grahamgilbert deleted the codex/fix-ci-lint branch July 21, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants