fix: honor out_index in single-page builder - #426
Open
ratmav wants to merge 1 commit into
Open
Conversation
the single-page builder ignored the out_index config option and wrote
its page to {dir}/index.qmd.qmd — a doubled extension that also produced
broken inventory uris. the cause was an ordering bug: __init__ assigned
self.out_index after load_layout, so BuilderSinglePage always saw the
class default. setting a sidebar under single-page separately crashed
deep in _generate_sidebar with an opaque AttributeError.
resolves #1
- assign out_index before load_layout so single-page reads the configured value
- strip a trailing page suffix in BuilderSinglePage.load_layout so the default yields index.qmd and out_index="reference" yields reference.qmd
- raise a clear error when a sidebar is set under single-page instead of crashing
- add regression tests for the default page, out_index, and sidebar rejection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the single-page builder ignored the out_index config option and wrote its page to {dir}/index.qmd.qmd — a doubled extension that also produced broken inventory uris. the cause was an ordering bug: init assigned self.out_index after load_layout, so BuilderSinglePage always saw the class default. setting a sidebar under single-page separately crashed deep in _generate_sidebar with an opaque AttributeError.
resolves sixfeetup#1