Skip to content

feat: Lightbox in md and zoom improvements #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterchinman merged 3 commits into from
Jun 16, 2026
Merged

feat: Lightbox in md and zoom improvements #3842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc56853
feat: use shared Lightbox for md/tasks image previews
claude Jun 8, 2026
00a9723
improve lightbox zoom behavior
peterchinman Jun 16, 2026
e50c44b
biome
peterchinman Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions js/app/packages/core/component/LexicalMarkdown/component/decorator/MarkdownImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { internalDrag } from '@core/directive/internalDragState';

false && internalDrag;

import { Lightbox } from '@core/component/Lightbox';
import { toast } from '@core/component/Toast/Toast';
import { debouncedDependent } from '@core/util/debounce';

Expand All @@ -11,9 +12,8 @@ import { $isImageNode, type ImageDecoratorProps } from '@lexical-core';
import { calculateEffectiveDimensions } from '@lexical-core/utils/media';
import ImageIcon from '@phosphor/image-broken.svg';
import LoadingSpinner from '@phosphor/spinner.svg';
import XIcon from '@phosphor/x.svg';
import { debounce } from '@solid-primitives/scheduled';
import { Button, cn, Layer } from '@ui';
import { cn, Layer } from '@ui';
import {
$createNodeSelection,
$getNodeByKey,
Expand Down Expand Up @@ -386,23 +386,8 @@ export function MarkdownImage(props: ImageDecoratorProps) {
</div>

<Dialog.Portal>
<Dialog.Overlay class="fixed inset-0 z-modal bg-modal-overlay items-center justify-center" />
<div class="fixed inset-0 z-modal w-screen h-screen flex items-center justify-center bg-transparent">
<Dialog.Content class="relative max-w-[65%] max-h-[80vh] flex items-center justify-center">
<div class="absolute bg-surface top-2 right-2 flex flex-row">
<Dialog.CloseButton>
<Button variant="ghost" size="icon-md">
<XIcon />
</Button>
</Dialog.CloseButton>
</div>
<img
crossorigin="anonymous"
class="max-w-full max-h-[80vh] size-auto object-contain"
src={imageUrl()}
/>
</Dialog.Content>
</div>
<Dialog.Overlay class="fixed inset-0 z-modal bg-modal-overlay pattern-edge-muted pattern-diagonal-4" />
<Lightbox src={imageUrl} imageId={() => props.id} navigationHidden />
</Dialog.Portal>
</Dialog>
);
Expand Down
Loading
Loading