Skip to content

fix(channel): focus input when pressing enter with no message selected #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterchinman wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

fix(channel): focus input when pressing enter with no message selected #3874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion js/app/packages/channel/Channel/create-channel-hotkeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ export function createChannelHotkeys(options: CreateChannelHotkeysOptions) {
return options.messageById().get(id);
};

const focusInput = () => {
inputEl?.querySelector<HTMLElement>('[contenteditable]')?.focus();
};

registerHotkey({
scopeId: messageListScope,
hotkey: 'arrowup',
Expand All @@ -79,7 +83,7 @@ export function createChannelHotkeys(options: CreateChannelHotkeysOptions) {
options.navigation()?.markUserIntent('down');
options.navigation()?.scrollToId(id, { align: 'nearest' });
} else {
inputEl?.querySelector<HTMLElement>('[contenteditable]')?.focus();
focusInput();
}
return true;
},
Expand Down Expand Up @@ -112,6 +116,19 @@ export function createChannelHotkeys(options: CreateChannelHotkeysOptions) {
},
});

registerHotkey({
scopeId: messageListScope,
hotkey: 'enter',
hotkeyToken: TOKENS.channel.focusInput,
description: 'Focus input',
registrationType: 'add',
condition: () => !hasSelection(),
keyDownHandler: () => {
focusInput();
return true;
},
});

registerHotkey({
scopeId: messageListScope,
hotkey: 'e',
Expand Down
Loading