feat(soup): impl notification filters for foreign entities, github pr's in signal

js/app/packages/app/component/app-sidebar/soup-filter-presets.ts

@@ -64,6 +64,11 @@ const getInboxSignalFilters = () => {
       chatUpdatedAt: { gte: twoWeeksAgo },
       folderDone: false,
       folderUpdatedAt: { gte: twoWeeksAgo },
+      // Foreign entities (e.g. GitHub PRs) with a not-done notification.
+      // Referencing `fef` also opts them into the signal query (otherwise
+      // defineQueryFilters excludes unreferenced entity types). Rendering is
+      // still gated on the supported-foreign-entities flag client-side.
+      foreignEntityDone: false,
       emailShared: 'exclude',
     },
     exclude: getDisabledSnippetSubtypeExclude(),

js/app/packages/app/component/next-soup/filters/configs/general.ts

@@ -26,6 +26,7 @@ export const inboxFilter = config({
       channelDone: false,
       chatDone: false,
       folderDone: false,
+      foreignEntityDone: false,
     },
     emailView: 'inbox',
   },

js/app/packages/app/component/next-soup/filters/filter-store/compile.ts

@@ -114,6 +114,8 @@ const FIELD_CONFIG: Record<
   callStatus: { target: 'callf', field: 'Status' },
   callAttended: { target: 'callf', field: 'Attended' },
   foreignEntityRecordId: { target: 'fef', field: 'id' },
+  foreignEntitySeen: { target: 'fef', field: 'ns' },
+  foreignEntityDone: { target: 'fef', field: 'nd' },
   crmCompanyId: { target: 'ccf', field: 'id' },
   crmCompanyHidden: { target: 'ccf', field: 'hidden' },
 };

js/app/packages/app/component/next-soup/filters/filter-store/types.ts

@@ -66,6 +66,8 @@ export type ScalarFieldFilters = {
   chatDone?: boolean;
   folderSeen?: boolean;
   folderDone?: boolean;
+  foreignEntitySeen?: boolean;
+  foreignEntityDone?: boolean;
   callStatus?: CallStatus;
   callAttended?: boolean;
   crmCompanyHidden?: boolean;

js/app/packages/app/component/next-soup/filters/inbox-filters.ts

@@ -128,7 +128,9 @@ export function signalFilter(entity: EntityData): boolean {
       // Automations only show in the Agents > Scheduled tab, not Inbox.
       return false;
     case 'foreign':
-      return false;
+      // Foreign entities (e.g. GitHub PRs) are gated by the inbox query on the
+      // user's not-done notifications, so they're signal whenever returned.
+      return true;
   }
 }
 

js/app/packages/service-clients/service-search/generated/models/foreignEntityFilters.ts

@@ -4,6 +4,7 @@
  * search_service
  * OpenAPI spec version: 0.1.0
  */
+import type { NotificationFilters } from './notificationFilters';
 
 /**
  * Filters for foreign entity records.
@@ -19,4 +20,7 @@ export interface ForeignEntityFilters {
 participant (GitHub `involves:me` semantics for `github_pull_request` records). False or
 absent applies no filter. Serialized in filter ASTs as the `"me"` literal. */
   includes_me?: boolean;
+  /** Filter by the notification state of the foreign entity (e.g. whether the requesting user's
+GitHub PR notification is done/seen). */
+  notification_filters?: NotificationFilters;
 }

js/app/packages/service-clients/service-search/openapi.json

@@ -2105,6 +2105,10 @@
           "includes_me": {
             "type": "boolean",
             "description": "When true, only return foreign entities whose metadata lists the requesting user as a\nparticipant (GitHub `involves:me` semantics for `github_pull_request` records). False or\nabsent applies no filter. Serialized in filter ASTs as the `\"me\"` literal."
+          },
+          "notification_filters": {
+            "$ref": "#/components/schemas/NotificationFilters",
+            "description": "Filter by the notification state of the foreign entity (e.g. whether the requesting user's\nGitHub PR notification is done/seen)."
           }
         }
       },

js/app/packages/service-clients/service-storage/generated/schemas/foreignEntityFilters.ts

@@ -4,6 +4,7 @@
  * document_storage_service
  * OpenAPI spec version: 0.1.0
  */
+import type { NotificationFilters } from './notificationFilters';
 
 /**
  * Filters for foreign entity records.
@@ -19,4 +20,7 @@ export interface ForeignEntityFilters {
 participant (GitHub `involves:me` semantics for `github_pull_request` records). False or
 absent applies no filter. Serialized in filter ASTs as the `"me"` literal. */
   includes_me?: boolean;
+  /** Filter by the notification state of the foreign entity (e.g. whether the requesting user's
+GitHub PR notification is done/seen). */
+  notification_filters?: NotificationFilters;
 }

js/app/packages/service-clients/service-storage/generated/zod.ts

@@ -7998,6 +7998,23 @@ export const postItemsSoupBody = zod
           .describe(
             'When true, only return foreign entities whose metadata lists the requesting user as a\nparticipant (GitHub `involves:me` semantics for `github_pull_request` records). False or\nabsent applies no filter. Serialized in filter ASTs as the `\"me\"` literal.'
           ),
+        notification_filters: zod
+          .object({
+            done: zod
+              .boolean()
+              .nullish()
+              .describe(
+                'Filter by notification done state. `Some(true)` selects done\nnotifications; `Some(false)` selects not-done notifications.'
+              ),
+            seen: zod
+              .boolean()
+              .nullish()
+              .describe(
+                'Filter by notification seen state. `Some(true)` selects seen\nnotifications; `Some(false)` selects not-seen notifications.'
+              ),
+          })
+          .optional()
+          .describe('Notification state filters for channel message queries.'),
       })
       .optional()
       .describe('Filters for foreign entity records.'),

js/app/packages/service-clients/service-storage/openapi.json

@@ -14059,6 +14059,10 @@
           "includes_me": {
             "type": "boolean",
             "description": "When true, only return foreign entities whose metadata lists the requesting user as a\nparticipant (GitHub `involves:me` semantics for `github_pull_request` records). False or\nabsent applies no filter. Serialized in filter ASTs as the `\"me\"` literal."
+          },
+          "notification_filters": {
+            "$ref": "#/components/schemas/NotificationFilters",
+            "description": "Filter by the notification state of the foreign entity (e.g. whether the requesting user's\nGitHub PR notification is done/seen)."
           }
         }
       },