Fixes issues #111 & #112 - DIFAR module crashes & Deep Learning Detections in DIFAR module#1
Open
BrianSMiller wants to merge 6 commits intomacster110:mainfrom
Open
Fixes issues #111 & #112 - DIFAR module crashes & Deep Learning Detections in DIFAR module#1BrianSMiller wants to merge 6 commits intomacster110:mainfrom
BrianSMiller wants to merge 6 commits intomacster110:mainfrom
Conversation
Check for a null pointer exception in OverlayMarks that was causing a crash on startup.
Fix a bug that I found where the DIFAR module was crashing the symbol manager. Seems that this was due to this subclass of clip generator having a null value for it's uniqueName. I've fixed by checking for null values and assigning a generic symbol when null.
Set flag in DeepLearning detector so that detections are considered 'clips' by Pamguard. This allows them to be processed automatically in the DIFAR Localisation module (and maybe others).
Fix a bug in DIFAR module where the frequency limits of automated detections were not being set properly by the DIFAR module.
Fix bug in deep learning detector where duration (in samples) was being set to number of samples in a hop instead of the number of samples in a segment.
macster110
pushed a commit
that referenced
this pull request
Apr 29, 2024
macster110
force-pushed
the
main
branch
2 times, most recently
from
1eae8da to
e0ec433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crashes in the DIFAR module (issue PAMGuard#111) , and feature request to use Deep Learning Detections as input into the DIFAR module (issue PAMGuard#112).