Draft
Conversation
Make it 2% of the cross section.
Update repository to 1.01.00, in particular the MadGraph submodule got updated to v3.6.5.
The process run originally in the ref was different from the one included in the repository.
Reference samples have been generated using MadtRex on top of vanilla MadGraph and not on top of CUDACPP, so there is a slightly larger uncertainty when comparing those ref samples with the reweighted samples that start from CUDACPP-generated events. We are not interested to check theat they are digit-by-digit correct, but that they are almost correct with each other.
In some cases, the imported model during reweighting is still Python 2, so we need to setup autoconversion at the beginning of the launch card if the model is not trivial and it is not the Standard Model
Collaborator
Author
|
After an exchange with @zeniheisser, we decided that it may be worth to generate the event samples in advance, so that tests go a bit faster. This would imply:
This can be done in another workflow file separated from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new step in
testsuite_oneprocessworkflow to check MadtRex according to validation tests running the reweighting on MC samples generated using the process folders obtained during thecodegenstep in the CI itself.Notice that the references files have been generated using vanilla MadGraph and not CUDACPP (like in this case) - except for
nobm_pp_ttWthat has been regenerated with CUDACPP - so we increased the maximum threshold for the results difference to 5%.