nox-review: fix wip click decorator - #80
Open
lsix wants to merge 1 commit into
Open
Conversation
Since f50bebb, the function the `@cli.command` decorator sees is the one generated with `@setup_nixpkgs_config`, i.e. `_` (c.f. nox/review.py:66). Therefore it cannot properly guess figure the `wip` function name. This explains the behaviour observed in NixOS/nixpkgs#29684: ``` $ nox-review --help Usage: nox-review [OPTIONS] COMMAND [ARGS]... Review a change by building the touched commits Options: -k, --keep-going Keep going in case of failed builds --dry-run Don't actually build packages, just print the commands that would have been run --help Show this message and exit. Commands: _ difference between working tree and a commit pr changes in a pull request ``` This commit basically does what is done in nixpkgs to fix the behaviour change: NixOS/nixpkgs@5f0a7cd
matthewbauer
approved these changes
Sep 29, 2017
|
I ran into this problem on nixpkgs. The documented command With the current state of nox only |
Author
|
@bobvanderlinden there is already a fix in nixpkgs (NixOS/nixpkgs@5f0a7cd). I just ported it to stable so as soon as the channel has been updated by hydra it will be fixed in |
|
Ah, great. Thank you! |
Owner
|
Thanks for that! I can't merge it right now, because that would break the CI (the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since f50bebb, the function the
@cli.commanddecorator sees is the one generated with@setup_nixpkgs_config, i.e._(c.f. nox/review.py:66). Therefore itcannot properly guess figure the
wipfunction name.This explains the behaviour observed in
NixOS/nixpkgs#29684:
This commit basically does what is done in nixpkgs to fix the behaviour
change:
NixOS/nixpkgs@5f0a7cd