nox-review: Fix --keep-going - #86
Open
dezgeg wants to merge 1 commit into
Open
Conversation
Currently e.g. `nox-review --keep-going wip --against HEAD^` fails
because extra-args is being set to `[["--keep-going"]]`, that is a list
of list containing a string. This crashes nox later on:
File "/nix/store/82f7gbp1byi5qp78rjrapzl7z97whjkp-nox-0.0.6/lib/python3.6/site-packages/nox/review.py", line 38, in build_in_path
click.echo('Invoking {}'.format(' '.join(command)))
TypeError: sequence item 1: expected str instance, list found
Remove the extra list to fix the crash.
|
It looks like 0d43970#diff-017d389e6f983a6d2eeee21343eb3c63R73 (and thereby |
das-g
approved these changes
Dec 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently e.g.
nox-review --keep-going wip --against HEAD^failsbecause extra-args is being set to
[["--keep-going"]], that is a listof list containing a string. This crashes nox later on:
Remove the extra list to fix the crash.