Skip to content

apply 2to3 script - #24

Open
iuvbio wants to merge 2 commits into
mafm:masterfrom
iuvbio:2to3
Open

apply 2to3 script#24
iuvbio wants to merge 2 commits into
mafm:masterfrom
iuvbio:2to3

Conversation

@iuvbio

@iuvbio iuvbio commented Jun 6, 2022

Copy link
Copy Markdown

No description provided.

Comment thread ledger.py
Comment on lines +153 to +154
if len(list(amounts.keys())) == 1:
return list(amounts.values())[0]

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is list really necessary here?

Comment thread ledger.py Outdated
return result
## else account_names = [] => print for all accounts
accounts = accounts_dict.keys()
accounts = list(accounts_dict.keys())

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space

Comment thread ledger.py

if (args.ignore_transactions_outside_dates):
print "# Ignoring transactions earlier/later than specified dates."
print("# Ignoring transactions earlier/later than specified dates.")

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent with single and double quotes

@finsteininvest

Copy link
Copy Markdown

I have a running Python 3 version: https://github.com/finsteininvest/ledger3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants