Feat : Added undo/redo for recipe setting changes#393
Conversation
👋 Thanks for your PR, @siddjs19!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
c4a892f to
633b333
Compare
|
@siddjs19 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Closed the previous PR and recreated this one after resolving merge/conflict issues and cleaning up the branch. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@siddjs19 deployment has failed please fix it |
|
Hey @siddjs19! The CI build check hasn't run on this PR yet — this usually happens when the PR was opened before the CI was fully set up, or if the branch hasn't been updated recently. To trigger the build check, please rebase onto the latest git fetch origin
git rebase origin/main
git push --force-with-leaseThis will re-trigger CI. If you hit any merge conflicts in Once CI passes and the Vercel deployment is authorized, we'll review and merge. 🚀 |
|
Hey @siddjs19! While looking at the diff more carefully, I spotted a code error that needs fixing before CI can pass: Double // NEW (added)
const {
file, duration, recipe, status, progress, result, error,
updateRecipe, undo, redo, canUndo, canRedo,
handleFileSelect, handleExport, reset,
} = useVideoEditor();
// OLD (still present — needs to be removed)
const {
file, duration, recipe, status, progress,
result, error, updateRecipe,
handleFileSelect, handleExport, cancelExport, reset,
} = useVideoEditor();This will cause a Please rebase onto |
|
Hey @siddjs19! 👋 We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged. Please add a recording to this PR that shows:
How to record:
Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details. Thanks for contributing to Reframe! 🎬 |
Removed resetSettings function that updates the recipe.
Removed resetSettings function that updates the recipe.
…eframe into feat/undo-redo-export
|
Hey @magic-peach ! https://drive.google.com/drive/folders/1VN_Eqx37ir6GcyRFGsluKGHwXPKsoqz8?usp=drive_link start undo-redo video from 0:45 also tell what should i do about lint and tsc warnings added drive link because file sizes were large I used ctrl+z and others also but screen recorder didn't capture keyboard pressed keys |
Summary
Implemented undo/redo support for export settings.
Changes
Fixes #108