Feat: add text overlay#734
Conversation
|
@mohammed-danyal is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @mohammed-danyal!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @mohammed-danyalBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
resolved the merge conflicts, please check @magic-peach |
|
Hey @mohammed-danyal! This PR has merge conflicts with git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseOnce rebased and CI passes, this can be reviewed for merge. |
Removed duplicate state declaration for editingTextId.
|
hi @magic-peach , thank you for the reminder, I've fixed the merge conflicts. |
Removed the updateRecipe function and added currentTime state.
|
@magic-peach can you please merge the pr! |
|
Hey @mohammed-danyal! Thanks for working on text overlay support — that's a meaningful feature. This PR currently has merge conflicts with git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease origin <your-branch>Once rebased and CI passes, I'll do a full review of the implementation. |
|
Hey @mohammed-danyal! This PR has merge conflicts with git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseOnce rebased and CI passes, the text overlay feature will be reviewed for merging. Thanks! |
Description
Implemented a lightweight text overlay system for the video editor.
This PR adds support for:
The implementation was intentionally kept minimal to preserve the existing architecture and avoid unnecessary UI refactors.
Related Issue
Closes #717
Type of Contribution
Participant Info
Screen Recording
bandicam.2026-05-19.18-46-24-180.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in