Skip to content

Feat: add text overlay#734

Open
mohammed-danyal wants to merge 11 commits into
magic-peach:mainfrom
mohammed-danyal:feat/add-text-overlay
Open

Feat: add text overlay#734
mohammed-danyal wants to merge 11 commits into
magic-peach:mainfrom
mohammed-danyal:feat/add-text-overlay

Conversation

@mohammed-danyal
Copy link
Copy Markdown
Contributor

Description

Implemented a lightweight text overlay system for the video editor.

This PR adds support for:

  • creating text overlays directly on the video preview
  • dragging/repositioning text on the canvas
  • inline text editing
  • basic text styling controls
  • toolbar integration near the rotate controls
  • rendering text overlays during export

The implementation was intentionally kept minimal to preserve the existing architecture and avoid unnecessary UI refactors.

Related Issue

Closes #717

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: Mohammed-danyal
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

bandicam.2026-05-19.18-46-24-180.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@mohammed-danyal is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @mohammed-danyal!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

✅ PR Format Check Passed — @mohammed-danyal

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 19, 2026
@mohammed-danyal mohammed-danyal changed the title Feat/add text overlay Feat: add text overlay May 19, 2026
@mohammed-danyal
Copy link
Copy Markdown
Contributor Author

resolved the merge conflicts, please check @magic-peach

@magic-peach
Copy link
Copy Markdown
Owner

Hey @mohammed-danyal! This PR has merge conflicts with main. Please rebase to resolve them:

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease

Once rebased and CI passes, this can be reviewed for merge.

@mohammed-danyal
Copy link
Copy Markdown
Contributor Author

hi @magic-peach , thank you for the reminder, I've fixed the merge conflicts.

@mohammed-danyal
Copy link
Copy Markdown
Contributor Author

@magic-peach can you please merge the pr!
thank you

@magic-peach
Copy link
Copy Markdown
Owner

Hey @mohammed-danyal! Thanks for working on text overlay support — that's a meaningful feature.

This PR currently has merge conflicts with main. Please rebase:

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease origin <your-branch>

Once rebased and CI passes, I'll do a full review of the implementation.

@magic-peach magic-peach removed type:bug Bug fix type:docs Documentation labels May 23, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @mohammed-danyal! This PR has merge conflicts with main that need to be resolved before review. Please rebase:

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease

Once rebased and CI passes, the text overlay feature will be reviewed for merging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Text Overlay Support

2 participants