fix: increase extractMetadata timeout from 500ms to 5s (#729)#737
Open
MehtabSandhu11 wants to merge 1 commit into
Open
fix: increase extractMetadata timeout from 500ms to 5s (#729)#737MehtabSandhu11 wants to merge 1 commit into
MehtabSandhu11 wants to merge 1 commit into
Conversation
|
@MehtabSandhu11 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @MehtabSandhu11!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @MehtabSandhu11Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Increased the
extractMetadatatimeout from 500ms to 5000ms andimproved the timeout error message.
Why
500ms is too aggressive for large files (>200MB) on mid/low-end devices
or busy browser tabs. The browser can legitimately take a few seconds to
parse metadata headers, causing valid files to be rejected with a silent
Layer 4 error and no recovery path for the user.
5s was chosen over the issue's suggested 10–15s because
onloadedmetadatafires as soon as headers are parsed — not after the full file loads — so
anything beyond 5s is almost certainly a corrupt or unsupported file, not
a slow device.
Changes
500→5000"Video metaData load timeout"→"Video metadata load timeout — the file may be too large or the device too slow. Please try again."Closes #729
Please add the appropriate labels for GSSoC so I can get the points.