feat: export file size estimation#744
Open
Pranav-IIITM wants to merge 1 commit into
Open
Conversation
Extends the existing exportEstimate.ts utility with a more accurate file size estimation model. Changes: - Fix preset resolution lookup — previously always used customWidth/Height even when a named preset (1080p, 4K, etc.) was selected - Replace 4-bucket CRF lookup with exponential curve fit to real H.264 reference points (CRF 18 ≈ 8 Mbps, 23 ≈ 3 Mbps, 30 ≈ 0.6 Mbps) - Fix speed scaling — was incorrectly dividing bitrate by speed; speed now only scales output duration - Add sqrt-damped resolution multiplier for more accurate high-res estimates - Add format overhead factor (webm ~15% smaller, mkv ~2% larger than mp4) - Add audio track estimate (AAC 128 kbps) - Add unit tests covering all estimation behaviours Closes magic-peach#657
|
@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
level:advanced
Contributor
✅ PR Format Check Passed — @Pranav-IIITMBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
type:feature
Contributor
👋 Thanks for your PR, @Pranav-IIITM!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the existing
exportEstimate.tsutility with a more accurate file size estimation model.Changes Made
customWidth/customHeighteven when a named preset (1080p,4K, etc.) was selectedwebm≈ 15% smallermkv≈ 2% largermp4baselineAAC 128 kbps)Related Issue
Closes #657
Type of Contribution
Participant Info
Screen Recording
Video_Estimated-file-size.mp4
Checklist
bun run lintpassesbunx tsc --noEmitpassesconsole.logstatements left in