fix: prevent accidental navigation during video export#745
Open
Ram-sah19 wants to merge 1 commit into
Open
Conversation
|
@Ram-sah19 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Ram-sah19Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Ram-sah19!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where refreshing or closing the browser tab during an active video export would immediately cancel the export process without warning.
Changes Made
Updated the
beforeunloadevent listener inuseVideoEditor.tsAdded
e.returnValue = ""to ensure modern browsers trigger the native confirmation dialogRefined the
shouldWarncondition to activate only during:loading-engineexportingRemoved the
donestatus from the warning condition so the event listener detaches correctly after a successful exportThese changes improve export reliability and help prevent accidental interruption during long-running video exports.
Related Issue
Closes #740
Type of Contribution
Participant Info
Screenshot
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in