Skip to content

fixed the overlapping content#746

Open
pratyuxxhh wants to merge 1 commit into
magic-peach:mainfrom
pratyuxxhh:fix/custom-frame-overlapping-value-inside-field
Open

fixed the overlapping content#746
pratyuxxhh wants to merge 1 commit into
magic-peach:mainfrom
pratyuxxhh:fix/custom-frame-overlapping-value-inside-field

Conversation

@pratyuxxhh
Copy link
Copy Markdown

Description

Fixed the overlapping issue in the custom width/height input fields where the frame/border was covering the numeric input and spinner controls.

Additionally, fixed incorrect frame ratio rendering behavior:

  • Ratios like 1:1 were not displaying as proper squares.
  • Width and height scaling behavior was inconsistent.
  • Updated the ratio handling logic so frame dimensions now render correctly according to the selected aspect ratio.

Also corrected independent resizing behavior:

  • Changing width now affects only width.
  • Changing height now affects only height unless aspect ratio lock is enabled.

Related Issue

Closes #738

Type of Contribution

  • Bug fix
  • GSSoC contribution

Participant Info

  • GitHub username: pratyuxxhh
  • Contribution level: Intermediate

Screen Recording

Reframe.Resize.trim.and.export.videos.in.your.browser.-.Google.Chrome.2026-05-19.21-43-56.mp4

Recording / Loom link:

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@pratyuxxhh is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @pratyuxxhh

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @pratyuxxhh!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] the custom frame UI is not good

1 participant