Skip to content

fix : fixed the inverted slider#749

Open
pratyuxxhh wants to merge 1 commit into
magic-peach:mainfrom
pratyuxxhh:fix/inverted-quality-slider
Open

fix : fixed the inverted slider#749
pratyuxxhh wants to merge 1 commit into
magic-peach:mainfrom
pratyuxxhh:fix/inverted-quality-slider

Conversation

@pratyuxxhh
Copy link
Copy Markdown

Description

Fixed the inverted export quality slider logic in the export settings UI.

Changes made:

  • Corrected the slider behavior so that moving the slider toward the right now properly represents High quality output.
  • Moving the slider toward the left now correctly represents Small file / lower quality output.
  • Fixed incorrect label mapping between slider position, CRF values, and estimated file size.

Correct behavior after fix:

  • Right side → High quality, lower CRF, larger file size
  • Left side → Smaller file, higher CRF, smaller file size

Also added before/after screenshots to demonstrate the fix.

Related Issue

Closes #741

Type of Contribution

  • Bug fix
  • GSSoC contribution

Participant Info

  • GitHub username: pratyuxxhh
  • Contribution level: Intermediate

Screenshots 

Before
image

After
image

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@pratyuxxhh is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @pratyuxxhh!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @pratyuxxhh

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The Quality slider is inverted

1 participant