fix(mobile): ensure export button is full-width with 44px touch targe…#772
Merged
magic-peach merged 1 commit intoMay 20, 2026
Merged
Conversation
magic-peach#57) - Add min-h-[44px] to the export button to guarantee the minimum 44px touch target height on all screen sizes (WCAG 2.5.5 recommendation) - w-full already present so button spans full container width on mobile (grid collapses to single column on screens < lg breakpoint) - Also update ffmpeg.test.ts to match new buildAudioFilter(speed, normalizeAudio) signature introduced in upstream main Closes magic-peach#57
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Rucha0901Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
magic-peach
added
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #57
Fixes the Export button layout on mobile devices to ensure it is full-width and meets the minimum 44px touch target height.
What Changed
src/components/VideoEditor.tsxmin-h-[44px]to the Export button's className — guarantees the WCAG 2.5.5 recommended minimum touch target height on all screen sizes.w-fullwhich makes it span the full container width. On mobile (<lgbreakpoint), the grid collapses to a single column so the button fills the entire viewport width.Before / After
Acceptance Criteria
min-h-[44px]