fix(ui): hide number input spinners to prevent value visibility overl…#778
Open
Rucha0901 wants to merge 1 commit into
Open
fix(ui): hide number input spinners to prevent value visibility overl…#778Rucha0901 wants to merge 1 commit into
Rucha0901 wants to merge 1 commit into
Conversation
…ap (magic-peach#776) Browser-native increment/decrement arrows on <input type='number'> fields overlap with entered values in narrow containers, making text hard to read. Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes: - [appearance:textfield] — Firefox - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari Affected inputs: - TrimControl.tsx — Start (sec) and End (sec) number fields - PresetSelector.tsx — Custom Width (px) and Height (px) fields Keyboard up/down arrow key stepping still works; only the visual spinner arrows are removed, which fully resolves the overlap/readability bug. Closes magic-peach#776
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Rucha0901Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Summary
Closes #776
Numeric input fields in the customization panel show browser-native increment/decrement
spinner arrows that overlap with the entered value, making text partially or fully hidden —
especially noticeable in Chromium-based browsers (Brave, Chrome, Edge) on Windows.
Root Cause
<input type="number">renders built-in spinner arrows inside the input box.In narrow containers the arrows sit on top of the typed value, reducing readability.
Fix
Suppress the spinner UI with cross-browser Tailwind arbitrary-value classes added
directly to the affected inputs'
className:[appearance:textfield][&::-webkit-outer-spin-button]:appearance-none[&::-webkit-inner-spin-button]:appearance-noneFiles Changed
src/components/TrimControl.tsxsrc/components/PresetSelector.tsxAcceptance Criteria
tsc --noEmitpasses clean)