feat: add Pillarbox Blur background option for Fit mode#788
Open
Kritika200520 wants to merge 4 commits into
Open
feat: add Pillarbox Blur background option for Fit mode#788Kritika200520 wants to merge 4 commits into
Kritika200520 wants to merge 4 commits into
Conversation
|
@Kritika200520 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Kritika200520!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Kritika200520Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
@Kritika200520 the build is failing please fix it |
Author
|
@magic-peach i did some changes please review it again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Pillarbox Blur background option when resizing videos using the Fit (letterbox/pillarbox) mode. Instead of showing solid black bars in the empty letterbox space, users can now toggle a scaled-up, blurred version of the video playing in the background.
Key changes:
EditRecipeto supportblurBackgroundstate.FramingControlcomponent under Fit mode.buildVideoFilterusingsplit,scale,crop,boxblur, andoverlayto overlay the source video on top of a blurred background.src/lib/tests/ffmpeg.test.tsto verify the generated filter strings for letterbox, blurred background, and crop scenarios.Related Issue
Closes # [685]
Type of Contribution
Participant Info
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in