feat(export): enable multi-threaded ffmpeg and add vercel security he…#813
Open
codewithakshyaaa wants to merge 1 commit into
Open
feat(export): enable multi-threaded ffmpeg and add vercel security he…#813codewithakshyaaa wants to merge 1 commit into
codewithakshyaaa wants to merge 1 commit into
Conversation
|
@codewithakshyaaa is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @codewithakshyaaa!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @codewithakshyaaaBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description
This PR resolves a critical issue where clicking the "Export" button would completely freeze the browser tab. The application was previously running
FFmpeg.wasmin single-threaded mode on the main JavaScript thread, locking the browser's event loop during heavy CPU-bound video processing.To fix this, I have transitioned the video processing pipeline to use Multi-Threaded (MT) FFmpeg.wasm, shifting the heavy processing execution to Web Workers via
SharedArrayBuffer(SAB).Changes Made
SRI_HASHESwith valid Subresource Integrity cryptographic signatures (sha384) for@ffmpeg/core-mt@0.12.10to safely fetch multi-threaded assets from jsDelivr.vercel.jsonconfigurations to inject required security headers across all routes:Cross-Origin-Opener-Policy: same-originCross-Origin-Embedder-Policy: require-corp"handle": "filesystem"route fromvercel.jsonto avoid any potential deployment framework routing edge cases.How to Test / Verification
vercel devor access the generated Vercel Preview deployment.Integrity mismatchorSharedArrayBuffersecurity blocking warnings appear.Related Issue
Type of Contribution
Participant Info
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in