fix: resolve high contrast hover visibility issue #820
Open
Ram-sah19 wants to merge 7 commits into
Open
Conversation
|
@Ram-sah19 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Ram-sah19!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Ram-sah19Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an accessibility issue affecting interactive UI elements in High Contrast Mode.
Under
data-theme="high-contrast", several buttons and tab switchers became unreadable on hover due to a white-on-white color combination caused byhover:bg-[var(--border)].Closes #797
Problem
In High Contrast Mode:
--surfacebecomes black (#000000)--borderbecomes white (#FFFFFF)hover:bg-[var(--border)]switched their background to white on hoverThis resulted in:
Affected components included:
Solution
A centralized accessibility fix was implemented in
src/app/globals.css.Instead of adding component-level conditional logic, a targeted CSS override was introduced specifically for High Contrast Mode using:
The rule:
#FFFFFF)*, spans, SVG icons, etc.) to black (#000000)This achieves WCAG AAA compliant contrast ratios (21:1).
Changes Included
Added high-contrast hover accessibility overrides in
src/app/globals.cssFixed invisible text/icons for:
hover:bg-[var(--border)]Testing
Steps to Verify
Run the application locally:
Enable High Contrast Mode using the theme toggle.
Hover over:
Expected Result
Hovered elements should:
Impact