fix: improve accessibility of number input spinner controls#824
Open
Ram-sah19 wants to merge 8 commits into
Open
fix: improve accessibility of number input spinner controls#824Ram-sah19 wants to merge 8 commits into
Ram-sah19 wants to merge 8 commits into
Conversation
|
@Ram-sah19 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Ram-sah19!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Ram-sah19Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Description**
This pull request improves the usability and accessibility of native number input fields by making browser-provided increment/decrement spinner controls consistently visible across supported browsers and devices.
Previously, WebKit-based browsers only displayed spinner arrows when the input was hovered or focused, which reduced discoverability and negatively impacted touch-device usability.
Problem
Native number inputs in Chromium/WebKit browsers (
::-webkit-inner-spin-buttonand::-webkit-outer-spin-button) default to hidden or low-opacity states until hover/focus interaction occurs.This caused several UX issues:
Affected areas included:
Solution
A lightweight global CSS enhancement was added in
src/app/globals.css.The implementation:
Targets WebKit spin button pseudo-elements
Forces spinner controls to remain visible using:
Preserves native browser behavior and accessibility
Avoids introducing custom input implementations or additional TSX logic
This keeps the solution:
Changes Included
Added global visibility overrides for:
::-webkit-inner-spin-button::-webkit-outer-spin-buttonImproved discoverability for:
Testing
Steps to Verify
Run the application locally:
Navigate to:
Observe the number input fields without hovering.
Expected Result
Accessibility Impact
Closes #798