fix: add JS validation for custom preset width/height inputs (#24)#829
Open
rahul-rajak-nsut wants to merge 2 commits into
Open
fix: add JS validation for custom preset width/height inputs (#24)#829rahul-rajak-nsut wants to merge 2 commits into
rahul-rajak-nsut wants to merge 2 commits into
Conversation
- Validate width/height in handleWidthChange and handleHeightChange - Reject values outside 16–7680 range and NaN before updating state - Add autoComplete='off' to width and height inputs Fixes magic-peach#24
|
@rahul-rajak-nsut is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @rahul-rajak-nsut!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @rahul-rajak-nsutBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added JavaScript-level validation in
PresetSelector.tsxto prevent invaliddimension values (0, -1, NaN, or out-of-range numbers) from being stored in
state. Previously, users could type invalid values via keyboard, bypassing
HTML
min/maxattributes, which caused FFmpeg encoding errors on export.Changes made:
handleWidthChange: now rejects values outside 16–7680 and NaNhandleHeightChange: now rejects values outside 16–7680 and NaNautoComplete="off"to both custom dimension inputsRelated Issue
Closes #24
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link:
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in