feat: add tooltip to disabled Export button (#983)#984
Merged
magic-peach merged 1 commit intoMay 23, 2026
Conversation
magic-peach#983) When no video is uploaded, the Export button now shows a native browser tooltip — "Upload a video to enable export" — on hover. Tooltip is removed once a video is loaded. No extra JS or dependencies added.
|
@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
level:beginner
Contributor
👋 Thanks for your PR, @Pranav-IIITM!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Pranav-IIITMBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
magic-peach
added
gssoc:approved
chavanGaneshDatta
pushed a commit
to chavanGaneshDatta/reframe
that referenced
this pull request
May 23, 2026
magic-peach#983) (magic-peach#984) When no video is uploaded, the Export button now shows a native browser tooltip — "Upload a video to enable export" — on hover. Tooltip is removed once a video is loaded. No extra JS or dependencies added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When no video is uploaded, the Export button now shows a native browser tooltip ("Upload a video to enable export") on hover via a conditional
titleprop. The tooltip is removed once a video is loaded. No extra JS, state, or dependencies added — single prop change inVideoEditor.tsx.Related Issue
Closes #983
Type of Contribution
Participant Info
Screen Recording
feat_add.tooltip.to.disabled.Export.button.1.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in