Updated GetRecentBlockHash to GetLatestBlockHash#56
Merged
GabrielePicco merged 3 commits intomagicblock-labs:masterfrom Feb 1, 2025
Merged
Updated GetRecentBlockHash to GetLatestBlockHash#56GabrielePicco merged 3 commits intomagicblock-labs:masterfrom
GabrielePicco merged 3 commits intomagicblock-labs:masterfrom
Conversation
…ana RPC Client. Included core code and tests, but left interface-instances for convenience.
GabrielePicco
changed the title
GabrielePicco
requested changes
Jan 31, 2025
Contributor
GabrielePicco
left a comment
GabrielePicco
left a comment
There was a problem hiding this comment.
Thanks @MCollector for the contribution! Changes overall look great, but using Result instead of await on RPC calls results in unexpected behaviour in some environment (e.g. Unity WebGL).
Please update the PR so that it always await on GetLatestBlockHashAsync()
GabrielePicco
requested changes
Feb 1, 2025
Contributor
GabrielePicco
left a comment
GabrielePicco
left a comment
There was a problem hiding this comment.
Thanks again for the contribution. It looks ready, but please use var instead of the explicit types (e.g RequestResult<Solana.Unity.Rpc.Messages.ResponseValue<LatestBlockHash>>) to improve source-code readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated GetRecentBlockHash to GetLatestBlockHash instances on the Soana RPC Client. Included core code and tests, but left interface-instances for convenience.
Problem
GetRecentBlockHash is deprecated and some Nodes do not support this call anymore (ie Helius)
Solution
Replaced all the calls with GetLatestBlockHash() which is the advised RPC Call.