fix: better logging message when ledger is reset

[Jovian-Dsouza]

Summary

Replaces confusing u64::MAX slot logging with semantic LedgerInitState enum to clearly indicate whether the ledger is freshly initialized or resuming from existing data.

Solution

Introduced LedgerInitState enum with two variants:

• Fresh: Ledger was reset/is a fresh start with no existing blocks
• Resuming { last_slot: Slot }: Resuming from an existing slot

The enum provides:

• Clear, human-readable display format via Display trait implementation
• Semantic type safety preventing misuse of sentinel values

Compatibility

• No breaking changes

Testing

• Unit tests added for LedgerInitState Display and slot_for_accountsdb methods
• Build successful with no warnings
• Tests pass: test_ledger_init_state_fresh_display and test_ledger_init_state_resuming_display

Expected output

Fresh start (with --reset):
INFO ... Ledger initialized ledger_state="fresh start (no existing blocks)"

Resuming from existing data:
INFO ... Ledger initialized ledger_state="resuming from slot 12345"

Checklist

• docs updated (if needed)
• closes bug: ledger reset = true setting no longer respected #834

Summary by CodeRabbit

• Refactor
  • Updated ledger initialization to provide enhanced state information, better distinguishing between fresh and resumed configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR introduces a new public enum LedgerInitState with Fresh and Resuming { last_slot: Slot } variants to explicitly distinguish ledger initialization modes. A slot_for_accountsdb() method is added to return Slot::MAX for fresh initialization and the provided slot for resuming. The init() function's return type is changed from ApiResult<(Ledger, Slot)> to ApiResult<(Ledger, LedgerInitState)>, returning Fresh when config.reset is true and Resuming otherwise. The magic_validator.rs file is updated to propagate the new state type and derive the AccountsDB slot through the enum's method.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure config.reset = true is respected to initialize ledger fresh with Slot::MAX [#834]	✅
Create explicit representation of fresh vs. resuming ledger initialization states [#834]	✅
Ensure ledger reads max blockhash slot when not resetting [#834]	✅

Suggested reviewers

• thlorenz
• bmuddha

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Jovian-Dsouza]

please review @thlorenz