perf: optimize instrumentation in hot paths

[thlorenz]

Summary

Optimizes instrumentation overhead in hot paths by avoiding pubkey/signature stringification when accounts are already in the local bank. The transaction signature is now carried through the call chain and only stringified in the cold path (when actually fetching from chain).

CLOSES: #867

Details

Hot Path Optimization

Removed eager signature/pubkey stringification from the hot path functions:

• send_transaction: Changed to #[instrument(skip_all)], removed .record() call
• ensure_transaction_accounts: Changed to #[instrument(skip_all)]
• read_account_with_ensure: Changed to #[instrument(skip_all)]

Cold Path Signature Propagation

Extended AccountFetchOrigin::SendTransaction to carry the transaction signature:

• Changed from unit variant to SendTransaction(Signature)
• Added signature() accessor method
• Signature is a 64-byte memcpy (~1ns) vs base58 stringification (~500ns + heap alloc)

In fetch_and_clone_accounts (cold path), the signature is recorded on the span so it appears in all logs during chain fetch operations.

Documentation

Added explanatory comments to cold path functions in chain_laser_actor.rs, chain_pubsub_actor.rs, and subscription_reconciler.rs noting that pubkey stringification is acceptable there since network I/O dwarfs the cost.

Summary by CodeRabbit

• Chores

  • Improved observability and diagnostics by enhancing transaction signature tracing across request handling and chainlink operations.
  • Streamlined internal instrumentation attributes for more efficient logging.
  • Added explanatory documentation for telemetry instrumentation points.

• Refactor

  • Updated metric types to better track transaction context and origin information.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[github-actions]

Manual Deploy Available

You can trigger a manual deploy of this PR branch to testnet:

Deploy to Testnet 🚀

Alternative: Comment /deploy on this PR to trigger deployment directly.

⚠️ Note: Manual deploy requires authorization. Only authorized users can trigger deployments.

Comment updated automatically when the PR is synchronized.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request optimizes tracing instrumentation overhead by removing granular field logging from the local magicblock-aperture flow and concentrating instrumentation at the account-fetching stage in magicblock-chainlink. Changes include simplifying instrumentation attributes from targeted field logging to generic skip_all in aperture modules, introducing signature tracking through an updated AccountFetchOrigin enum, adding instrumentation at the chainlink fetch stage, and documenting where stringification overhead is acceptable on cold paths. Supporting comments and explicit return type annotations are added to clarify instrumentation decisions.

Assessment against linked issues

Objective	Addressed	Explanation
Remove instrumentation overhead in the local magicblock-aperture → magicblock-chainlink path [#867]	✅
Defer stringification overhead until account-fetching stage where it is negligible [#867]	✅
Preserve necessary telemetry by adding instrumentation at the appropriate stage [#867]	✅
Support signature tracking for instrumentation purposes [#867]	✅

Out-of-scope changes

Code Change	Explanation
Function signature change to explicit return type -> bool (magicblock-chainlink/src/remote_account_provider/subscription_reconciler.rs, line added with pub(crate) async fn unsubscribe_and_notify_removal...)	This signature modification introduces an explicit return type annotation but does not directly address the instrumentation overhead reduction objective. While the function already returns bool values internally, making the return type explicit appears to be a separate code clarity improvement rather than a performance optimization related to tracing overhead.

Suggested reviewers

• GabrielePicco
• lucacillario

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch thlorenz/logs-aperture-chainlink-optimization

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bmuddha]

LGTM, with minor nit

[bmuddha]

why not skip all?