Skip to content

Added culling for hitboxes outside the screen #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olvior wants to merge 1 commit into
base: 1.2.2.1
Choose a base branch
from
Open

Added culling for hitboxes outside the screen #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Source/Hitbox/HitboxRender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private void OnGUI()

private void DrawHitbox(Camera camera, Collider2D collider2D, HitboxType hitboxType, float lineWidth)
{
if (collider2D == null || !collider2D.isActiveAndEnabled)
if (collider2D == null || !collider2D.isActiveAndEnabled || ShouldCullCollider(camera, collider2D))
{
return;
}
Expand Down Expand Up @@ -186,5 +186,17 @@ private void DrawHitbox(Camera camera, Collider2D collider2D, HitboxType hitboxT

GUI.depth = origDepth;
}

private bool ShouldCullCollider(Camera camera, Collider2D collider2D)
{
Bounds bounds = collider2D.bounds;

Vector3 min = camera.WorldToViewportPoint(bounds.min);
Vector3 max = camera.WorldToViewportPoint(bounds.max);

bool overlap = (min.x < 1 && max.x > 0 && min.y < 1 && max.y > 0);

return !overlap;
}
}
}
}