Spectrum v1.2.000000c1

[johnmilson125-png]

This pull request includes:

Program Optimization:

• Improved resizing
• Improved color display
• App has been made customizable.
• Added new menu (decided to delete it soon)
• Added settings
• Added themes

Code Optimization:

• Code Improved and checked

---

Theme Modes:

const struct ThemeModeManager themeModeManager[] = {
    {"Default Mode", ThemeMode::Mode0},
    {"Mode 1", ThemeMode::Mode1},
    {"Mode 2", ThemeMode::Mode2},
    {"Mode 3", ThemeMode::Mode3},
    {"Mode 4", ThemeMode::Mode4}
};    

---

ThemeMode::Mode0 or Default Mode:

ThemeMode::Mode1 or Mode 1 (temporary names):

ThemeMode::Mode2 or Mode 2 (temporary names):

ThemeMode::Mode3 or Mode 3 (temporary names):

ThemeMode::Mode4 or Mode 4 (temporary names):

[majockbim]

So far the PR looks awesome, the logo and config system are exactly what i had in mind.

Before moving on I had some requests:

• 1. Merge Conflicts

  • The merge conflicts are because this was built on top of v1.0.0 before v1.1.0 was pulled, can you pull from main and resolve the conflicts?

• 2. JSON Parser

  • For the JSON finder, i think looking for any .json in the directory is a bit risky/unsafe, if a user has an unrelated package.json or data.json in the same folder it could cause issues. Can we change it to look for a specifically named file (spectrum.json) instead?

• 3. Example Config File

  • Could you include an example spectrum.json in the PR with all the available options and a short comment explaining what each one does? Just something users can drop into the same folder as the .exe and tweak. This would also make it much easier to document in the README.

• 4. Documentation

  • Please include a GNU license header in the settings.cpp and settings.hpp.
  • You can copy the text straight from the v1.2.0 visualizer.cpp!

other than that this is genuinely great work, excited to get these changes merged!

Side Note:

• Once the 3 points above are covered, I'll personally start working on v1.2.0 - on things like documentation, tweaks & changes, etc..

[majockbim]

Please refer to the comment I left on the PR for more detail on the requested changes.

Todo:

• Resolve merge conflicts
• Update JSON parser
• Add example spectrum.json file
• GNU documentation update

[johnmilson125-png]

well, let's talk about your notices!:

• Documentation

  • i'll start by adding GNU License on every file i create.

• Settings and JSON Finder

  • about settings.json and JSON Finder, i'll leave it as it is, but i'll make it finding themes and let the user choose one of these themes, and add specific settings file settings.json contains general settings of the program.

• Conflicts

  • about conflicts, yeah, i will resolve them!.

[majockbim]

Sounds good!

[johnmilson125-png]

Added new feature!

[johnmilson125-png]

Added new feature