feat: add update methods to Pages resource - #65
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesPages API updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Heads up — this is a dependency for makeplane/plane-mcp-server#190, which needs update_workspace_page()/update_project_page() to implement its update_page MCP tool. Would appreciate a look here so that PR can move forward. |
|
@akhil-vamshi-konam @sangeethailango I dont know if I am tagging you guys correctly but I think these features are important so we can use MCP properly, me and my team will be working heavily with wiki and it will be crucial to have these, any recommendations or anything so we can proceed with these faster? |
|
Hey @demetere @Galeforce1 , yes — I’ve raised the corresponding functionality in both the SDK and MCP:
The SDK PR includes the page update and archive/unarchive APIs, along with the relevant tests. For MCP, I raised #202 separately because we recently consolidated the tools, which changed how we define and expose them. We’ll get these reviewed and merged soon so the functionality can move forward smoothly. |
Overview
Adds
update_workspace_pageandupdate_project_pageto thePagesresource.Motivation
The
UpdatePagemodel already exists inplane/models/pages.py, but noresource method uses it — Pages currently supports list, retrieve,
create, and delete, but not update. This closes that gap, following the
exact pattern already used by
Cycles.update(),Projects.update(),and other resources (
self._patch(...)+data.model_dump(exclude_none=True)).Changes
Pages.update_workspace_page(workspace_slug, page_id, data)Pages.update_project_page(workspace_slug, project_id, page_id, data)No new models, no breaking changes — purely additive.
Summary by CodeRabbit