Skip to content

fix(web): apply all event types when updating a webhook #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khizarshah01 wants to merge 1 commit into
base: preview
Choose a base branch
from
+23 −8
Open

fix(web): apply all event types when updating a webhook #9620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions ...b/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/webhooks/[webhookId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { observer } from "mobx-react";
import useSWR from "swr";
import { EUserPermissions, EUserPermissionsLevel } from "@plane/constants";
import { TOAST_TYPE, setToast } from "@plane/propel/toast";
import type { IWebhook } from "@plane/types";
import type { IWebhook, TWebhookEventTypes } from "@plane/types";
// ui
// components
import { LogoSpinner } from "@/components/common/logo-spinner";
Expand Down Expand Up @@ -47,19 +47,34 @@ function WebhookDetailsPage({ params }: Route.ComponentProps) {
isAdmin ? () => fetchWebhookById(workspaceSlug, webhookId) : null
);

const handleUpdateWebhook = async (formData: IWebhook) => {
const handleUpdateWebhook = async (formData: IWebhook, webhookEventType: TWebhookEventTypes) => {
if (!formData || !formData.id) return;

const payload = {
let payload: Partial<IWebhook> = {
url: formData.url,
is_active: formData.is_active,
project: formData.project,
cycle: formData.cycle,
module: formData.module,
issue: formData.issue,
issue_comment: formData.issue_comment,
};

if (webhookEventType === "all") {
payload = {
...payload,
project: true,
cycle: true,
module: true,
issue: true,
issue_comment: true,
};
} else {
payload = {
...payload,
project: formData.project ?? false,
cycle: formData.cycle ?? false,
module: formData.module ?? false,
issue: formData.issue ?? false,
issue_comment: formData.issue_comment ?? false,
};
}

try {
await updateWebhook(workspaceSlug, formData.id, payload);
setToast({
Expand Down