Fix recovery cmd_vel hold behavior - #33
Merged
makers-pet merged 1 commit intoJul 22, 2026
Merged
Conversation
Collaborator
|
Thank you again, xbattlax! |
Collaborator
|
@xbattlax , I've given /cmd_vel holding a bit of a thought - it would be great to generalize health monitoring to any component. Can you please take a look at https://github.com/makerspet/oomwoo/tree/main/contributions/health-monitor ? |
Contributor
Author
|
Thanks, I took a look and opened #36 as a first health-monitor contract/prototype. It keeps Verification is in the PR body. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32.
Twistand re-publish it on each 20 Hz timer tick until the step deadlineclear_costmap, so the 0.1s nominal step duration is not reused as a service-result timeoutVerification
PYTHONPATH=contributions/recovery-safety/xbattlax/oomwoo_recovery_safety pytest contributions/recovery-safety/xbattlax/oomwoo_recovery_safety/testgit diff --checkpython3 -m compileall contributions/recovery-safety/xbattlax/oomwoo_recovery_safety/oomwoo_recovery_safety