Skip to content

Migrating MALA to Python 3.13 (and generally newer packages)#657

Merged
RandomDefaultUser merged 18 commits into
mala-project:developfrom
RandomDefaultUser:migrate_to_p13
May 23, 2025
Merged

Migrating MALA to Python 3.13 (and generally newer packages)#657
RandomDefaultUser merged 18 commits into
mala-project:developfrom
RandomDefaultUser:migrate_to_p13

Conversation

@RandomDefaultUser

@RandomDefaultUser RandomDefaultUser commented Apr 23, 2025

Copy link
Copy Markdown
Member

MALA has so far only been tested up to Python 3.10. I would like to extend that range, and in the process fix #559.

Steps:

  • Install MALA into a (local) python3.13 environment (this results in recent torch, numpy, etc. versions)
  • Get LAMMPS to work there
  • Get the TEM to work there (Problem building QE (total energy module) #559 , currently fighting with the distutils to meson migration)
  • Test and fix potential issues (all works except for the TEM)
  • Update versions in CI
  • Test backwards compatability to 3.10.x

Fixes #615.

@RandomDefaultUser RandomDefaultUser changed the title Migrating MALA to Python 3.13 (and generally newer submodules) Migrating MALA to Python 3.13 (and generally newer packages) Apr 24, 2025
@RandomDefaultUser RandomDefaultUser marked this pull request as draft April 29, 2025 15:11
@RandomDefaultUser RandomDefaultUser linked an issue Apr 29, 2025 that may be closed by this pull request
We need to put all QE .o files into a static lib and link that.
@elcorto

elcorto commented May 5, 2025

Copy link
Copy Markdown
Member

@RandomDefaultUser I have a branch based off your migrate_to_p13 in a fork of mine, which works around an f2py bug (as described in numpy/numpy#28902), will let us move to numpy 2.x and fixes #559. Since this PR is from your fork into upstream develop, how should we proceed?

@RandomDefaultUser

Copy link
Copy Markdown
Member Author

Can you do a PR from your branch to mine?
Elsewise, I could change the branch to mala-project:migrate_to_p13 and then you could do a PR?

@elcorto

elcorto commented May 8, 2025

Copy link
Copy Markdown
Member

Can you do a PR from your branch to mine? Elsewise, I could change the branch to mala-project:migrate_to_p13 and then you could do a PR?

I can PR from my version of that branch into yours, oh my :) RandomDefaultUser#8

@RandomDefaultUser RandomDefaultUser marked this pull request as ready for review May 23, 2025 09:44
@RandomDefaultUser RandomDefaultUser merged commit 2ca9b6e into mala-project:develop May 23, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASE warning message Update python version Problem building QE (total energy module)

2 participants