Conversation
nikw9944
changed the title
nikw9944
force-pushed
the
nikw/2669
branch
3 times, most recently
from
c22987b to
6dc35c6
Compare
Contributor
Author
|
Note that merging this to main will require deploying device-health-oracle to testnet/mainnet-beta before promoting this change to those environments. |
| Data: map[string]any{ | ||
| "err": map[string]any{ | ||
| "InstructionError": []any{ | ||
| json.Number(string(rune('0' + instructionIndex))), |
Contributor
There was a problem hiding this comment.
Minor comment:
I think this works since we enforce maxBatchSize. But if someone writes a new test in the feature that directly uses makeInstructionError(10) or higher. It would silently produce wrong test data and potentially cause confusing test failures. I think fmt.Sprintf("%d", instructionIndex) formats an integer as its decimal representation so it's safer.
martinsander00
approved these changes
Jan 26, 2026
…for writing to device.health and link.health; device-health-oracle now updates health status
gwfHPG4suqu1aiXEjCPyW9rZfKnb9zQqdNt4iyqiA1D | gwfHPG4suqu1aiXEjCPyW9rZfKnb9zQqdNt4iyqiA1D
martinsander00
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification