client: support multi-tunnel latency probing and best IP selection#2739
Open
client: support multi-tunnel latency probing and best IP selection#2739
Conversation
- doublezerod: probe interfaces with UserTunnelEndpoint=true in addition to device PublicIp - doublezero: select best latency IP when device has multiple tunnel endpoints
…tunnel probing - add CLI flag to control whether UserTunnelEndpoint interfaces are probed - when disabled (default): only probe device PublicIp (original behavior) - when enabled: probe PublicIp AND UserTunnelEndpoint interfaces - update tests to cover flag enabled/disabled behavior
packethog
force-pushed
the
ss/multitunnel_latency
branch
from
7a94ee5 to
433d5b4
Compare
| // | ||
| // Configuration: 200 devices, each with 1 tunnel endpoint interface = 400 probe targets | ||
| // (200 PublicIp + 200 interface IPs). This simulates a realistic production deployment. | ||
| func BenchmarkLatencyManagerMemoryStability(b *testing.B) { |
martinsander00
approved these changes
Jan 28, 2026
snormore
approved these changes
Jan 29, 2026
| // 1. Memory efficiency: [4]uint8 is 4 bytes inline vs net.IP which is a slice (24 byte header + heap allocation) | ||
| // 2. Direct assignment: allows zero-copy from serviceability.Device.PublicIp without conversion | ||
| // Convert to net.IP when needed via: net.IP(PublicIp[:]) | ||
| PublicIp [4]uint8 |
Contributor
There was a problem hiding this comment.
Suggested change
| PublicIp [4]uint8 | |
| PublicIP [4]uint8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
UserTunnelEndpoint=truein addition to the device'sPublicIp--latency-probe-tunnel-endpointsfeature flagbest_latency()in doublezero CLI to select the IP with the lowest latency when a device has multiple tunnelendpoints, rather than just finding the first match
Testing Verification
test_best_latency_multi_ip_selects_best_ip_for_devicetest_best_latency_multi_ip_current_device_uses_best_iptest_best_latency_multi_ip_switches_when_better_device_existstest_best_latency_multi_ip_multiple_devicestest_best_latency_for_device_helperGetProbeTargets()with interface endpoints