Check that https://github.com/vrischmann/zig-sqlite/tree/use-upstream works#43
Closed
malcolmstill wants to merge 1 commit intomasterfrom
Closed
Check that https://github.com/vrischmann/zig-sqlite/tree/use-upstream works#43malcolmstill wants to merge 1 commit intomasterfrom
malcolmstill wants to merge 1 commit intomasterfrom
Conversation
malcolmstill
changed the title
malcolmstill
force-pushed
the
malcolm/use-upstream
branch
from
6474785 to
4743829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# Description
Check that we can build with https://github.com/vrischmann/zig-sqlite/tree/use-upstream
Seems we need to remove the
exe.linkLibrary(sqlite.artifact("sqlite"));line, otherwise everything looks fines.Other changes are around
ansi-termwhich requires some modifications, and we can now get away with not vendoring it explicitly.