Skip to content

Fix open TableCellAdapter and TableHeaderFooterAdapter #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmarcato wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix open TableCellAdapter and TableHeaderFooterAdapter #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Table/Cell Adapters/TableCellAdapter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ open class TableCellAdapter<Model: ElementRepresentable, Cell: ReusableViewProto

// MARK: - Adapter Helpers Functions -

public func dequeueCell(inTable table: UITableView, at indexPath: IndexPath?) -> UITableViewCell {
open func dequeueCell(inTable table: UITableView, at indexPath: IndexPath?) -> UITableViewCell {
guard let indexPath = indexPath else {
let castedCell = modelViewType as! UITableViewCell.Type
let cellInstance = castedCell.init()
Expand All @@ -53,7 +53,7 @@ open class TableCellAdapter<Model: ElementRepresentable, Cell: ReusableViewProto
return table.dequeueReusableCell(withIdentifier: reusableViewIdentifier, for: indexPath)
}

public func registerReusableCellViewForDirector(_ director: TableDirector) -> Bool {
open func registerReusableCellViewForDirector(_ director: TableDirector) -> Bool {
let id = reusableViewIdentifier
guard director.cellReuseIDs.contains(id) == false else {
return false
Expand Down Expand Up @@ -84,7 +84,7 @@ open class TableCellAdapter<Model: ElementRepresentable, Cell: ReusableViewProto
// MARK: - Supporting Functions -

@discardableResult
public func dispatchEvent(_ kind: TableAdapterEventID, model: Any?, cell: ReusableViewProtocol?, path: IndexPath?, params: Any?...) -> Any? {
open func dispatchEvent(_ kind: TableAdapterEventID, model: Any?, cell: ReusableViewProtocol?, path: IndexPath?, params: Any?...) -> Any? {
switch kind {
case .dequeue:
events.dequeue?(TableCellAdapter.Event(item: model, cell: cell, indexPath: path))
Expand Down
6 changes: 3 additions & 3 deletions Sources/Table/Header Adapter/TableHeaderFooterAdapter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public class TableHeaderFooterAdapter<View: UITableViewHeaderFooterView>: TableH

// MARK: - Helper Function s-

public func registerHeaderFooterViewForDirector(_ director: TableDirector) -> String {
open func registerHeaderFooterViewForDirector(_ director: TableDirector) -> String {
let id = reusableViewIdentifier//View.reusableViewIdentifier()
guard director.headerFooterReuseIdentifiers.contains(id) == false else {
return id
Expand All @@ -88,12 +88,12 @@ public class TableHeaderFooterAdapter<View: UITableViewHeaderFooterView>: TableH
}
}

public func dequeueHeaderFooterForDirector(_ director: TableDirector) -> UITableViewHeaderFooterView? {
open func dequeueHeaderFooterForDirector(_ director: TableDirector) -> UITableViewHeaderFooterView? {
return director.table?.dequeueReusableHeaderFooterView(withIdentifier: reusableViewIdentifier)
}

@discardableResult
public func dispatch(_ event: TableSectionEvents, isHeader: Bool, view: UIView?, section: Int) -> Any? {
open func dispatch(_ event: TableSectionEvents, isHeader: Bool, view: UIView?, section: Int) -> Any? {
switch event {
case .dequeue:
events.dequeue?(HeaderFooterEvent(header: isHeader, view: view, at: section))
Expand Down