Skip to content

Pack booleans before integers, to avoid accidental mis-casting #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoCuul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pack booleans before integers, to avoid accidental mis-casting #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/SwiftMsgPack/Encoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ public extension Data {
try self.pack(string: value_str)
}

// BOOLEAN VALUES
else if let value_bool = obj as? Bool {
try self.pack(boolean: value_bool)
}

// UNSIGNED INT
else if let value_u8 = obj as? UInt8 { // 8 BIT
//try self.pack(signedInt: Int(value_u8))
Expand Down Expand Up @@ -133,11 +138,6 @@ public extension Data {
else if let value_char = obj as? Character {
try self.pack(string: String(value_char))
}
// BOOLEAN VALUES
else if let value_bool = obj as? Bool {
try self.pack(boolean: value_bool)
}

// ARRAY
else if let value_array = obj as? [Any?] {
try self.pack(array: value_array)
Expand Down