docs: add requirements section - #14
Conversation
|
/slopper report |
There was a problem hiding this comment.
Code Review
This pull request adds a 'Requirements' section to the README.md file specifying compiler, CMake, and Boost versions. The review feedback correctly identifies inconsistencies between these new requirements and the existing documentation and CMakeLists.txt, providing a suggestion to align the GCC and CMake versions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - C++20 compatible compiler (GCC 11+, Clang 14+, MSVC 2022+) | ||
| - CMake 3.20+ | ||
| - Boost 1.81+ (Beast, Asio, URL) |
There was a problem hiding this comment.
There are inconsistencies between this new Requirements section and the existing Prerequisites section (lines 212-215), as well as CMakeLists.txt:
- CMake:
CMakeLists.txtspecifiescmake_minimum_required(VERSION 3.10)and the prerequisites section listsCMake 3.10+, but here it saysCMake 3.20+. - GCC: The prerequisites section lists
GCC 12+, but here it saysGCC 11+.
Let's align these to ensure consistency across the documentation and build files.
| - C++20 compatible compiler (GCC 11+, Clang 14+, MSVC 2022+) | |
| - CMake 3.20+ | |
| - Boost 1.81+ (Beast, Asio, URL) | |
| - C++20 compatible compiler (GCC 12+, Clang 14+, MSVC 2022+) | |
| - CMake 3.10+ | |
| - Boost 1.81+ (Beast, Asio, URL) |
🔴 Slopper — PR BlockedThis PR was automatically closed by Slopper — reported by maintainer @malvads via
Powered by slopper |
Test PR for report via PR creation