[HOLD - merge after docker-build-pipe PR#8] feat: DEVENV-9681 push straight to Harbor, retire Artifactory leg#3
Merged
Conversation
Invert the producer: bake now pushes images directly to prod Harbor (REGISTRY_PREFIX -> harbor_host/namespace/image) instead of pushing to Artifactory and copying across. Drops the Artifactory docker login and the Artifactory build-metadata PUT. Per-target metadata is attached to the already-pushed Harbor image (oras attach) and the build-index pushed to builds/<image>:<build_id> (oras push) - the same path contract as docker-build-pipe run.sh and k8s-apps-config update-app-manifest.sh. Legacy registry_* inputs and ARTIFACTORY_TOKEN are kept defined but optional so existing caller repos don't break; ARTIFACTORY_TOKEN remains available as a build secret via BAKE_SECRETS for any Dockerfile that still pulls an Artifactory base at build time. Mirrors docker-build-pipe Phase 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD
Do not merge until docker-build-pipe PR#8 (the Bitbucket-side twin) is merged and green. Both producers do the same inversion; we flip them one at a time so a broken build is attributable. This is the GitHub Actions half of Phase 5 (DEVENV-9681).
What this does
Inverts the GitHub Actions producer from build → push Artifactory → copy to Harbor into build → push straight to Harbor, mirroring
docker-build-pipe/bin/run.shPhase 5.REGISTRY_PREFIXnow points at Harbor (harbor_host/namespace/image), sobakepushes images directly to prod Harbor — no cross-registryimagetools createcopy.bake) and the Artifactory build-metadatacurlPUT.oras attach; the build-index is pushed tobuilds/<image>:<build_id>viaoras push— the same path contract asdocker-build-pipe/bin/run.sh:417andk8s-apps-config/bin/update-app-manifest.sh:137(no namespace segment).Compatibility
Legacy inputs/secrets are kept defined but optional so existing caller repos don't break before they're cleaned up:
registry_host/registry_username→required: false, no longer a push target.ARTIFACTORY_TOKEN→required: false; still available as a build secret viaBAKE_SECRETSfor any Dockerfile that pulls an Artifactory base at build time.push_to_harbor→ deprecated / no-op (Harbor is the sole push target).Verify before merge
builds/<image>:<build_id>.feat/DEVENV-9681-harbor-build-indexPR (which predates the prodharbor_hostdefault and would roll it back to platform).Refs: DEVENV-9681