powershell-lsp: bound Pester bootstrap to 5.x (test-infra) + refresh #66987 upstream record (000120)#81
Merged
Merged
Conversation
…pin guard (000120)
…ve filed state (000120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatch 000120 (combined train; NO version bump on any leg). Two legs land here; leg 2 (the rule-rationale survey) is report-only and rides the dispatch outbox.
Leg 1 -- bound the Pester bootstrap to the 5.x major (test-infra only)
Pester 6.0.0 went GA on the PowerShell Gallery 2026-07-07.
tests/run-tests.ps1resolved Pester at three points that were all unbounded upward, so a runner-image change or a fresh install could silently run the suite under Pester 6 with nobody deciding to upgrade. All three are now capped at the 5.x major:$_.Version.Major -ge 5->-eq 5Install-Module Pester ... -MinimumVersion 5.0.0gains-MaximumVersion 5.99.99Import-Module Pester -MinimumVersion 5.0.0gains-MaximumVersion 5.99.99(imports by name, an independent exposure)A text-pin guard in
tests/PowerShellLsp.Unit.Tests.ps1(the 000073 Should-Match-on-the-literal pattern) asserts all three bounds are present and fails RED if any one is removed -- demonstrated locally (reverted one bound, observed RED, restored). Test-infra only: no version bump, no CHANGELOG entry (the 000045 / 000049 / 000063 precedent). OQ1 resolved to-MaximumVersion 5.99.99(stays on latest 5.x; an exact-RequiredVersionpin would force a bootstrap edit on every 5.x patch for no measured benefit).Leg 3 -- refresh the #66987 upstream record to live filed state (docs-only)
Live
ghre-check (2026-07-08):anthropics/claude-code#66987is OPEN and was rewritten by Mike on 2026-07-06 to exactly the registrar silent-drop root cause (re-confirmed on Claude Code 2.1.201).docs/upstream/claude-code-lsp-registration.mdstill framed the report as "not posted upstream / a separate Mike-gated draft" -- now stale. Refreshed to record that the registration root cause is filed as #66987, to carry the remainder still unsaid upstream (the plugin-side 000075 allowlist guard) as a post-ready UNPOSTED comment, and to state a routing recommendation (no fresh issue; #66987 already is the dedicated issue). Nothing was posted.Held
HELD for Mike's review and merge. Merge, tag, release, and all external posting are Mike's gates.
https://claude.ai/code/session_01DzoUdcmERJpKo4kGqKnJGm